agf-running-sit-tests

$npx mdskill add pcliangx/AppGenesisForge/agf-running-sit-tests

Verifies component integration before code review using acceptance criteria.

  • Ensures independently developed components compose correctly after unit tests pass.
  • Depends on feature branch, unit tests, and docs/changes/ acceptance criteria.
  • Walks through acceptance criteria to verify integration of frontend, backend, DB, and external services.
  • Sinks evidence into progress/<role>.md for code review readiness.

SKILL.md

.github/skills/agf-running-sit-testsView on GitHub ↗
---
name: agf-running-sit-tests
description: Use when an execution-layer dev (frontend-dev / backend-dev / ai-agent-dev / ml-engineer / miniapp-dev) has finished feature code + Unit tests and is about to enter code-review. Provides the SIT scope, environment, AC-driven integration walk, and evidence sink (progress/<role>.md). SIT is now a dev-owned step, not a separate QA stage.
---

# Running System Integration Tests (SIT)

Use this skill when:

- A dev finished feature code + Unit tests and is about to enter code-review
- A dev needs to verify a fix doesn't regress integration (API ↔ DB ↔ external)

## What SIT is — and is not

**SIT** verifies that **independently-developed components compose correctly** — frontend ↔ backend ↔ DB ↔ external services. It is NOT:

- Unit tests (already covered by `pytest` / `vitest` on the branch before SIT)
- E2E tests (real browser + real user journey — run downstream after code-review)
- UAT (business owner final sign-off — product-lead drives, downstream of E2E)

You just wrote the Unit tests, so you have the clearest picture of the unit-vs-integration boundary. If a failure reproduces by running just the backend unit tests with mocks, it's a unit-level miss, not a SIT finding; fold it back into the unit suite rather than writing it up as a SIT defect.

## Pre-conditions

- [ ] Feature branch is rebased onto `main`
- [ ] All Unit tests passing on the branch (pytest / vitest green) + lint + typecheck green
- [ ] AC 来源可访问:`docs/changes/<change>/tasks.md`(AC↔scenario 映射,[ADR-012](../../../docs/adr/012-spec-driven-change-folders.md));旧 feature fallback `docs/prd/[feature]-[date].md`
- [ ] `.env.local` with SIT-mode flags configured (or `.env.sit` if a dedicated SIT config exists)
- [ ] **前端 SIT 专属**:MSW mock 来自 orval 生成产物(`*.msw.ts`),非手写——mock 与 OpenAPI 契约同源(见 ADR-006 / `coding.md` 契约纪律)

If any precondition fails: SendMessage product-lead, do not proceed.

## Environment

Default SIT environment is **local docker-compose**, brought up via the root Makefile(本地开发一键 SSOT,依赖管理走 uv——见 ADR-000;不要手写 pip/alembic/uvicorn 命令绕开 `uv.lock`):

```bash
# from repo root
make dev       # postgres + backend (uv) + frontend (pnpm) 一键起栈
make migrate   # apply latest schema (uv run alembic)
```

For LLM-dependent features, set provider env vars per `agf-wiring-multi-llm-sdk` skill. Use a **dedicated SIT API key** with a hard daily spend cap so a runaway test doesn't drain the budget.

## Execution sequence

Walk every AC from `docs/changes/<change>/tasks.md`(旧 feature fallback `docs/prd/[feature].md`). For each AC at the integration layer:

1. **Setup** — record exact starting state (DB rows / fixture / user logged in)
2. **Action** — step-by-step what triggers the integration (frontend button click → API call → DB write → external service callback)
3. **Expected** — copy the AC verbatim
4. **Actual** — capture HTTP status, response body excerpt, DB row diff, log lines
5. **Verdict** — Pass / Fail / Blocked (with reason)

> **Verify, don't assume.** Don't write "Passed" because the code looks right. Run the action, capture the actual response, compare. Per `.claude/standards/coding.md` "Verify before assert" — paste the actual command output into the progress entry.

## Evidence collection

For each AC verdict:

- HTTP responses: `curl -i` output or browser DevTools Network export
- DB state changes: `psql -c "SELECT ..."` before/after dumps
- Logs: relevant lines from backend console + frontend console
- Screenshots: only when UI behavior is the subject of the AC

Keep evidence inline in the `**SIT 证据**` section of `progress/<role>.md` (small payloads). Large/binary artifacts → store under `progress/evidence/[feature]/` and reference by path.

## Evidence Output

SIT no longer produces a standalone report under `docs/qa/`. All evidence lives in `progress/<role>.md` under the `**SIT 证据**` section of the task entry — pass = single AC-tagged line (`✅ AC-N (integration): <一句话>`), fail/blocked expands命令 + 输出 + 偏差.

Format authority: `.claude/standards/ac-lifecycle.md` → **完整条目格式** (5-section format 状态 / Skills / SIT 证据 / 质量门 / 下一步 + the `**SIT 证据**` block rules). The progress file is archived into `docs/qa/[feature]-process-log.md` after UAT sign-off (product-lead), so SIT evidence survives without a separate report artifact.

## Hand-off

完成 SIT 自跑后,**先自检再报告**——跑 `bash .claude/scripts/agf-advisory.sh progress/<role>.md`(advisory 机筛统一入口,ADR-026 D2)机筛 placeholder / 漏证据 / pass 含失败 token / 质量门矛盾(advisory,不阻断),把 flag 的修掉再 SendMessage,省一轮 code-review 打回。**这是全链路唯一一次机筛**:reviewer 的 SIT Audit 不重跑 advisory(ADR-011 决策 2 + ADR-026 D2)。然后:

- **All AC pass**: SendMessage product-lead — "Implementation + SIT done, ready for code-review",引用 `progress/<role>.md` 条目路径 + 时间戳
- **Some AC fail / blocked**: 仍写完 `progress/<role>.md` 的 SIT 段(如实记录 fail / blocked),但 SendMessage 写明阻塞原因与影响范围,由 product-lead 决定本轮是否就修
- 不再直接 SendMessage 下游 QA 角色(已不参与 SIT);E2E 由 product-lead 在 code-review (含 SIT Audit) 通过后单独启动

## Anti-patterns

- ❌ Marking AC as Pass without actually triggering the action
- ❌ Skipping ACs because "they look obviously fine"
- ❌ Lumping multiple ACs into one "Passed all" line — every AC needs its own verdict + evidence
- ❌ Running SIT against a stale environment (forgot to apply migrations / restart server)
- ❌ Using production API keys for SIT
- ❌ Skipping SIT to ship faster — code-reviewer will reject the SIT Audit (see `.claude/agents/code-reviewer.md` "SIT Audit" section) and you'll be sent back
- ❌ Treating a missing unit test as a SIT defect — fold it back into the unit suite, don't smuggle it through integration

More from pcliangx/AppGenesisForge

SkillDescription
agf-code-mapDeeply Understand (codemap) — 持久化代码图谱 + 变更影响分析 + 理解地图。接手遗留项目 Day-1 / PR 影响分析 / 解释陌生代码 / PRD·ADR 前现状理解时用。编排 tools/codemap/ 的 codemap CLI
agf-deploying-uatUse when deploy-engineer is about to deploy the merged-to-main code to the isolated local UAT stack (after code review + SIT Audit pass and merge, before qa-engineer runs E2E/UAT). Provides the applicability gate, pre-flight checks, isolated compose bring-up (independent project name + port offset +900), in-container migration, real-output smoke test, hand-off, and the deploy-report skeleton. Pairs with deployment.md "UAT 环境部署" contract and slash /agf-deploy-uat.
agf-design-disciplineUse when uiux-designer is about to produce a design spec (spec.md) or static HTML prototype, or frontend-dev is about to build UI from a design. Provides the anti-AI-slop design discipline layer — Brief Inference (Design Read), three aesthetic dials tuned for product UI, AI Tells blacklist with overrides, mechanically-checkable Pre-Flight. Sits above the token layer (DESIGN.md) and mechanical review (code-reviewer); does not redeclare tokens or guide non-shadcn design systems. Inspired by taste-skill, cropped for AGF product UI per ADR-013.
agf-releasing-appleUse when apple-release-engineer is about to build the signed distributable (TestFlight build / notarized DMG / internal package) from merged-to-main code (after apple code review + SIT Audit pass and merge, before apple-qa-engineer runs E2E/UAT). Provides the applicability gate, pre-flight checks, lane execution per channel, notarization, real-output smoke test, hand-off, and the release-report skeleton. Pairs with deployment.md §7 "Apple 发布" contract and slash /agf-apple-release.
agf-running-apple-sitUse when apple-dev has finished feature code + Unit tests (Swift Testing) and is about to enter code-review. Provides the Apple SIT scope (xcodebuild test + simulator per declared target), the AC-driven integration walk, APIProtocol-mock discipline, and evidence sink (progress/apple-dev.md). SIT is dev-owned; apple-code-reviewer audits the evidence.
agf-running-release-retroUse when product-lead is about to run a release retrospective after a successful MAJOR or MINOR release push (PATCH skipped). Provides applicability gate, pre-conditions, 7-step execution sequence, anti-patterns, and the verification gate before commit. Pairs with template docs/reviews/retro-_TEMPLATE.md and slash /agf-release-retro.
agf-skill-stocktakeUse when PL / tech-lead audits the content quality of AGF's own skills (`.claude/skills/agf-*/SKILL.md`). Provides the 5-dimension checklist (Actionability / Scope fit / Uniqueness vs CLAUDE.md+standards / Currency of pointers / Gate-binding validity), 5-verdict rubric (Keep/Improve/Update/Retire/Merge), reason-quality bar (反敷衍), and output skeleton. Triggered each MINOR release retro or manually.
agf-wiring-apple-llmUse when wiring LLM features into the Apple client (macOS / iOS) — streaming chat via the FastAPI multi-LLM gateway, or on-device inference (Apple Foundation Models / Core ML). Provides the route decision (gateway vs on-device), streaming transport pattern, env/config contract, offline & cost guardrails, and minimum verifications before declaring the integration done.
agf-wiring-multi-llm-sdkUse when wiring up or switching between China-domestic LLM providers (DeepSeek, Doubao/Volc Ark, Qwen/DashScope, MiniMax). Provides OpenAI-compatible adapter pattern, env-var contracts, fallback strategy, cost guardrails, and minimum verifications before declaring integration done.
agf-writing-adrUse when tech-lead is about to record an architecture decision (new tech stack member, deviation from baseline, deployment / observability / auth scheme choice). Provides ADR structure, version-audit appendix format, and "what NOT to ADR" guidance. Replaces ad-hoc copy from ADR-000.